Skip to content

fix(docs): align relay systemd install flags with actual CLI#6984

Open
Abdul-Moiz31 wants to merge 3 commits into
Infisical:mainfrom
Abdul-Moiz31:fix/docs-relay-systemd-install-flags
Open

fix(docs): align relay systemd install flags with actual CLI#6984
Abdul-Moiz31 wants to merge 3 commits into
Infisical:mainfrom
Abdul-Moiz31:fix/docs-relay-systemd-install-flags

Conversation

@Abdul-Moiz31

Copy link
Copy Markdown
Contributor

Context

`infisical relay systemd install` doesn't support `--enroll-method` or `--relay-id` — confirmed against its actual `--help` output (see #6979). Those flags only exist on `infisical relay start`. The systemd install examples in the docs were copied from the `start` command and fail with `unknown flag: --enroll-method`.

Fixes #6979

Changes

  • Updated the Token Auth and AWS Auth "Linux (systemd)" examples to use `install`'s actual flags (`--token` for org-type, `--type=instance --relay-auth-secret` for instance-type)
  • Documented `install`'s full flag set under `infisical relay systemd` so it's not confused with `relay start`'s flags

Steps to verify the change

  1. Run `infisical relay systemd install --help` and compare against the documented flags
  2. Confirm `--enroll-method` is not accepted by `install` (matches the error reported in Add support for enroll-method in systemd install for relay #6979)

Type

  • Docs

Checklist

  • Title follows the conventional commit format
  • Read the contributing guide

infisical relay systemd install does not support --enroll-method or
--relay-id (confirmed against its --help output in Infisical#6979) — those flags
only exist on relay start. The systemd install examples were copied from
relay start and silently failed with "unknown flag: --enroll-method".

Updates the examples to use the install subcommand's actual flags
(--token / --type=instance --relay-auth-secret) and documents its full
flag set.

Fixes Infisical#6979
@greptile-apps

greptile-apps Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR corrects the infisical relay systemd install examples in the docs, removing flags (--enroll-method, --relay-id) that do not exist on the install subcommand and replacing them with the correct flags (--type=instance, --relay-auth-secret). It also adds a full flag reference for install under the infisical relay systemd accordion to distinguish it from relay start.

  • Removed --enroll-method and --relay-id from both the Token Auth and AWS Auth systemd install examples, which were copied from relay start and caused unknown flag errors.
  • Added --type=instance and --relay-auth-secret to the AWS Auth systemd install example, with inline notes explaining the flag differences.
  • Documented the complete flag set for the install subcommand in the infisical relay systemd accordion.

Confidence Score: 4/5

Documentation-only change that corrects copy-paste errors in CLI examples; straightforward to verify against the CLI's --help output.

The flag corrections are well-reasoned and verifiable. The one minor concern is that the --token description in the new flag list says "machine identity access token" while the Token Auth example still uses the placeholder <enrollment-token> — these may refer to the same one-time token or two different token types, and the inconsistent terminology could mislead users about which token to supply.

docs/cli/commands/relay.mdx — the --token flag description under the install accordion should be checked for terminology consistency with the Token Auth example above it.

Important Files Changed

Filename Overview
docs/cli/commands/relay.mdx Fixes wrong flags in systemd install examples (removed --enroll-method/--relay-id, added --type=instance/--relay-auth-secret), adds explanatory notes and a full flag list for the install subcommand; minor terminology inconsistency between the --token description and the Token Auth example placeholder.

Reviews (1): Last reviewed commit: "fix(docs): align relay systemd install f..." | Re-trigger Greptile

Comment thread docs/cli/commands/relay.mdx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 51faacf7df

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread docs/cli/commands/relay.mdx Outdated
Comment thread docs/cli/commands/relay.mdx Outdated
Comment thread docs/cli/commands/relay.mdx Outdated
…ss token

The install example reused relay start's <enrollment-token> placeholder for
--token, but install's --token is a machine identity access token per its
own --help text, not the one-time enrollment token relay start uses.
relaySystemdInstallCmd requires --host (it doesn't store/look it up
server-side like relay start does) — add it to both install examples.

Also drop the --type=instance/--relay-auth-secret mapping for AWS-auth
relays: that's a separate static-secret instance mechanism and isn't
equivalent to relay start --enroll-method=aws --relay-id. There's no
systemd install path for AWS-authenticated relays today.
@Abdul-Moiz31

Copy link
Copy Markdown
Contributor Author

hi @varonix0 can you please review it

Thankyou. !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for enroll-method in systemd install for relay

1 participant